Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated doc to add dependencies for testing #8198

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

ahmadsharif1
Copy link
Contributor

I believe expecttest is a dependency for running tests.

Copy link

pytorch-bot bot commented Jan 4, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8198

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ac36864 with merge base f52fd33 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ahmadsharif1 ! One minor correction below but LGTM when addressed!

CONTRIBUTING.md Outdated Show resolved Hide resolved
@NicolasHug NicolasHug merged commit 71b27a0 into pytorch:main Jan 5, 2024
64 checks passed
Copy link

github-actions bot commented Jan 5, 2024

Hey @NicolasHug!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

ahmadsharif1 added a commit to ahmadsharif1/vision that referenced this pull request Jan 5, 2024
Co-authored-by: Ahmad Sharif <ahmads@fb.com>
facebook-github-bot pushed a commit that referenced this pull request Mar 19, 2024
Summary: Co-authored-by: Ahmad Sharif <ahmads@fb.com>

Reviewed By: vmoens

Differential Revision: D55062788

fbshipit-source-id: ada5c4cfb8728b1b61d01b75d800c2d7360cb241
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants