Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial version of segmentation reference scripts #820

Merged
merged 20 commits into from
May 10, 2019

Conversation

fmassa
Copy link
Member

@fmassa fmassa commented Mar 27, 2019

This is the segmentation counter part of #819

I've trained both FCN and DeepLabV3, and they give results within 3% of the reported numbers.

This will be heavily refactored once detection models are implemented.
In particular, many of the functionalities here will be cleaned up / generalized and moved into torchvision.


class SBDD(object):
def __init__(self, root, image_set='train', transforms=None):
self.root = root
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

os.path.expanduser(root)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll definitely improve those datasets.

BTW, there has been a SBD dataset that has been recently merged into master, so I'll be inheriting from it instead most probably

@codecov-io
Copy link

codecov-io commented Apr 24, 2019

Codecov Report

Merging #820 into master will increase coverage by 1.25%.
The diff coverage is 87.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #820      +/-   ##
==========================================
+ Coverage   56.61%   57.87%   +1.25%     
==========================================
  Files          38       46       +8     
  Lines        3432     3696     +264     
  Branches      540      561      +21     
==========================================
+ Hits         1943     2139     +196     
- Misses       1372     1431      +59     
- Partials      117      126       +9
Impacted Files Coverage Δ
torchvision/models/__init__.py 100% <100%> (ø) ⬆️
torchvision/models/segmentation.py 76.92% <76.92%> (ø)
torchvision/models/_utils.py 88.46% <88.46%> (ø)
torchvision/models/deeplabv3.py 92.64% <92.64%> (ø)
torchvision/transforms/functional.py 69.9% <0%> (-1.22%) ⬇️
torchvision/ops/boxes.py 51.42% <0%> (ø)
torchvision/ops/roi_pool.py 68.29% <0%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78ed423...778d783. Read the comment docs.

@fmassa fmassa force-pushed the segmentation-v0 branch from 4a937be to 349e611 Compare May 7, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants