-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add groups support to ResNet #822
Conversation
Codecov Report
@@ Coverage Diff @@
## master #822 +/- ##
=========================================
- Coverage 52.45% 52.4% -0.05%
=========================================
Files 35 35
Lines 3401 3408 +7
Branches 545 547 +2
=========================================
+ Hits 1784 1786 +2
- Misses 1485 1488 +3
- Partials 132 134 +2
Continue to review full report at Codecov.
|
ResNets and its variants find their place as a building block in many new models. So providing a flexibility in choosing the number of channels (besides choosing the layer configuration) would give more power and ease to users while constructing their own custom models. And since there is a relation between the number of channels and groups, the implementation is quite neat and will remind the user (experimenting the source code) about the relation proposed by the authors. |
@ekagra-ranjan just to make sure I understand, were you advocating for passing the |
I am supporting the BaseResNet implementation that you implemented earlier in the PR which has |
I'll be merging this as is for now to unblock a few other things, and I can add back BaseResNet in a follow-up implementation. |
This adds the necessary building blocks to add support for ResNeXt models in torchvision.
One thing worth discussion: should we let the user specify arbitrary number of channels in each layer (as is currently supported in
BaseResNet
), or just stick with the options that are necessary to cover ResNet / ResNeXt?