Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 2D numpy arrays as inputs for to_image #8256

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Allow 2D numpy arrays as inputs for to_image #8256

merged 3 commits into from
Feb 6, 2024

Conversation

mantasu
Copy link
Contributor

@mantasu mantasu commented Feb 5, 2024

Closes #8255

if the input is 2D, numpy.atleast_3d simply adds an extra dimension to the end which can then be safely permuted.

cc @vfdev-5

Copy link

pytorch-bot bot commented Feb 5, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8256

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 3100374 with merge base 8e71207 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link

Hi @mantasu!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the report and for the PR @mantasu ! I took the liberty to push a small unittest to your PR. LGTM, I'll merge when the CI is green. Thank you!

@NicolasHug NicolasHug merged commit 36d0e3e into pytorch:main Feb 6, 2024
75 of 77 checks passed
@mantasu mantasu deleted the to-image-fix branch February 6, 2024 13:39
facebook-github-bot pushed a commit that referenced this pull request Mar 20, 2024
Summary: Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>

Reviewed By: vmoens

Differential Revision: D55062777

fbshipit-source-id: 09475eeb59e2a31157e47e38ed978a4b0e86e29f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

to_image does not handle numpy 2D arrays
3 participants