Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allow_empty parameter to ImageFolder and related utils #8311

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

NicolasHug
Copy link
Member

Closes #8297

Copy link

pytorch-bot bot commented Mar 13, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8311

Note: Links to docs will display an error until the docs builds have been completed.

❌ 12 New Failures, 16 Unrelated Failures

As of commit b733bcd with merge base e00f4e6 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor comment regarding using the dataset test framework.

test/test_datasets.py Show resolved Hide resolved
@NicolasHug
Copy link
Member Author

linux tests are passing so I'll risk a merge (macos failure is unrelated). Thanks a lot for the review!

@NicolasHug NicolasHug merged commit 9563e3e into pytorch:main Mar 13, 2024
30 of 58 checks passed
@NicolasHug NicolasHug deleted the allow_empty branch March 13, 2024 13:29
facebook-github-bot pushed a commit that referenced this pull request Mar 20, 2024
…8311)

Reviewed By: vmoens

Differential Revision: D55062799

fbshipit-source-id: 0250b54ae613531f8309750ccd42028d4a4288f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

Allow empty class folders in ImageFolder
3 participants