Add concrete_args to feature extraction tracing. #8393

rwightman · 2024-04-23T17:05:57Z

No description provided.

pytorch-bot · 2024-04-23T17:05:59Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8393

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 17 New Failures, 4 Unrelated Failures

As of commit 6e5787c with merge base 305330f ():

NEW FAILURES - The following jobs have failed:

CMake / macos (macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
CMake / macos (macos-m1-stable) / macos-job (gh)
The process '/usr/bin/git' failed with exit code 128
CMake / windows (windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
CMake / windows (windows.g5.4xlarge.nvidia.gpu, cuda, 11.8) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Lint / python-types / linux-job (gh)
Tests / unittests-macos (3.10, macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
Tests / unittests-macos (3.11, macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
Tests / unittests-macos (3.12, macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
Tests / unittests-macos (3.8, macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
Tests / unittests-macos (3.8, macos-m1-stable) / macos-job (gh)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-macos (3.9, macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
Tests / unittests-windows (3.10, windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-windows (3.11, windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-windows (3.12, windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-windows (3.8, windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-windows (3.8, windows.g5.4xlarge.nvidia.gpu, cuda, 11.8) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-windows (3.9, windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

Build Windows Conda / pytorch/vision / upload / conda-py3_8-cpu (gh)
CMake / linux (linux.g5.4xlarge.nvidia.gpu, cuda, 11.8) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Prototype tests on Linux / unittests-prototype (3.8, linux.g5.4xlarge.nvidia.gpu, cuda, 11.8) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-linux (3.8, linux.g5.4xlarge.nvidia.gpu, cuda, 11.8) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2024-04-23T17:06:02Z

Hi @rwightman!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot · 2024-04-23T18:08:15Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

NicolasHug

Thanks @rwightman . Some minor comments below that I'll just address myself. LGTM otherwise.

NicolasHug · 2024-04-29T10:08:07Z

torchvision/models/feature_extraction.py

@@ -203,6 +203,7 @@ def _set_default_tracer_kwargs(original_tr_kwargs: Optional[Dict[str, Any]]) ->
 def get_graph_node_names(
    model: nn.Module,
    tracer_kwargs: Optional[Dict[str, Any]] = None,
+    concrete_args: Optional[Dict[str, Any]] = None,


Unfortunately this parameter must be added as the last parameter, otherwise there's a (low) risk of breaking code that is using non-keyword parameters. This API should have been using keyword-only parameters to avoid that, but it didn't.

NicolasHug · 2024-04-29T10:09:59Z

torchvision/models/feature_extraction.py

+            not be treated as Proxies. This parameter is experimental and
+            its backwards-compatibility is *NOT* guaranteed.


The original pytorch docs are confusing and also state https://pytorch.org/docs/stable/fx.html#torch.fx.Tracer.trace

Backwards-compatibility for this API is guaranteed.

🤔

github-actions · 2024-04-29T13:12:22Z

Hey @NicolasHug!

You merged this PR, but no labels were added.
The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

Reviewed By: vmoens Differential Revision: D57099459 fbshipit-source-id: 9e3a386f12f6a1a9e3a9b4708da8b6c0a6e72d87 Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Nicolas Hug <nh.nicolas.hug@gmail.com>

Add concrete_args to feature extraction tracing. Fix pytorch#6817

7aaf8dc

facebook-github-bot added the cla signed label Apr 23, 2024

NicolasHug approved these changes Apr 29, 2024

View reviewed changes

Address comments

2e6d7c7

NicolasHug added enhancement topic: feature extraction labels Apr 29, 2024

Merge branch 'main' into feature_extract_concrete_args

6e5787c

NicolasHug changed the title ~~Add concrete_args to feature extraction tracing. Fix #6817~~ Add concrete_args to feature extraction tracing. Apr 29, 2024

NicolasHug merged commit ff31b6e into pytorch:main Apr 29, 2024
28 of 48 checks passed

NicolasHug mentioned this pull request Apr 29, 2024

create_feature_extractor and get_graph_node_names should have a concrete_args argument #6817

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add concrete_args to feature extraction tracing. #8393

Add concrete_args to feature extraction tracing. #8393

rwightman commented Apr 23, 2024

pytorch-bot bot commented Apr 23, 2024 •

edited

Loading

facebook-github-bot commented Apr 23, 2024

facebook-github-bot commented Apr 23, 2024

NicolasHug left a comment

NicolasHug Apr 29, 2024

NicolasHug Apr 29, 2024

github-actions bot commented Apr 29, 2024

		not be treated as Proxies. This parameter is experimental and
		its backwards-compatibility is NOT guaranteed.

Add concrete_args to feature extraction tracing. #8393

Add concrete_args to feature extraction tracing. #8393

Conversation

rwightman commented Apr 23, 2024

pytorch-bot bot commented Apr 23, 2024 • edited Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8393

❌ 17 New Failures, 4 Unrelated Failures

facebook-github-bot commented Apr 23, 2024

Action Required

Process

facebook-github-bot commented Apr 23, 2024

NicolasHug left a comment

Choose a reason for hiding this comment

NicolasHug Apr 29, 2024

Choose a reason for hiding this comment

NicolasHug Apr 29, 2024

Choose a reason for hiding this comment

github-actions bot commented Apr 29, 2024

pytorch-bot bot commented Apr 23, 2024 •

edited

Loading