Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove #pragma comment(linker, "/include:_register_ops") #8414

Merged
merged 3 commits into from
May 9, 2024

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented May 8, 2024

Probably an artefact from years ago. CI is geen, so this is probably not needed anymore.

Copy link

pytorch-bot bot commented May 8, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8414

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 1c15bb0 with merge base 5367021 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamp

@NicolasHug NicolasHug merged commit c09cc69 into pytorch:main May 9, 2024
79 of 81 checks passed
@NicolasHug NicolasHug deleted the remove_include_register_ops branch May 9, 2024 10:42
facebook-github-bot pushed a commit that referenced this pull request May 20, 2024
…8414)

Reviewed By: vmoens

Differential Revision: D57565239

fbshipit-source-id: fecdb2fbfdea588d9e34135e8131c5e3030802be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants