Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ShuffleNet v2 #849

Merged
merged 3 commits into from
Apr 30, 2019
Merged

Add ShuffleNet v2 #849

merged 3 commits into from
Apr 30, 2019

Conversation

barrh
Copy link
Contributor

@barrh barrh commented Apr 12, 2019

Added 4 configurations: x0.5, x1, x1.5, x2
Added 2 pretrained models: x0.5, x1
Tested with Imagenet 1k.

Partially addresses: #645

TODO: re-upload the models from my branch, and update the URLs

barrh added 2 commits April 12, 2019 05:26
Added 4 configurations: x0.5, x1, x1.5, x2
Add 2 pretrained models: x0.5, x1
@codecov-io
Copy link

codecov-io commented Apr 12, 2019

Codecov Report

Merging #849 into master will increase coverage by 1.3%.
The diff coverage is 84.04%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #849     +/-   ##
========================================
+ Coverage      54%   55.3%   +1.3%     
========================================
  Files          36      37      +1     
  Lines        3346    3401     +55     
  Branches      549     551      +2     
========================================
+ Hits         1807    1881     +74     
+ Misses       1406    1385     -21     
- Partials      133     135      +2
Impacted Files Coverage Δ
torchvision/models/__init__.py 100% <100%> (ø) ⬆️
torchvision/models/shufflenetv2.py 83.87% <83.87%> (ø)
torchvision/datasets/caltech.py 19% <0%> (-2.14%) ⬇️
torchvision/datasets/sbd.py 31.66% <0%> (+0.08%) ⬆️
torchvision/models/resnet.py 83.55% <0%> (+0.21%) ⬆️
torchvision/datasets/celeba.py 16.09% <0%> (+1.35%) ⬆️
torchvision/datasets/imagenet.py 22.68% <0%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8759f30...4c8abb6. Read the comment docs.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks generally very good, thanks!

I've a question regarding the pre-trained model: what were the hyperparameters / how did you train them? Is the codebase available somewhere?

torchvision/models/shufflenetv2.py Outdated Show resolved Hide resolved
@barrh
Copy link
Contributor Author

barrh commented Apr 15, 2019

I didn't train the pretrained models. The weights were published here: https://github.com/ericsun99/Shufflenet-v2-Pytorch

@barrh
Copy link
Contributor Author

barrh commented Apr 28, 2019

@fmassa is there any other change request, or can we go on to merge this addition?

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I'll update the weights path in a later commit.

@fmassa fmassa merged commit 7a4845a into pytorch:master Apr 30, 2019
@barrh barrh deleted the shufflenet branch May 10, 2019 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants