-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ShuffleNet v2 #849
Add ShuffleNet v2 #849
Conversation
Added 4 configurations: x0.5, x1, x1.5, x2 Add 2 pretrained models: x0.5, x1
Codecov Report
@@ Coverage Diff @@
## master #849 +/- ##
========================================
+ Coverage 54% 55.3% +1.3%
========================================
Files 36 37 +1
Lines 3346 3401 +55
Branches 549 551 +2
========================================
+ Hits 1807 1881 +74
+ Misses 1406 1385 -21
- Partials 133 135 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks generally very good, thanks!
I've a question regarding the pre-trained model: what were the hyperparameters / how did you train them? Is the codebase available somewhere?
I didn't train the pretrained models. The weights were published here: https://github.com/ericsun99/Shufflenet-v2-Pytorch |
@fmassa is there any other change request, or can we go on to merge this addition? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I'll update the weights path in a later commit.
Added 4 configurations: x0.5, x1, x1.5, x2
Added 2 pretrained models: x0.5, x1
Tested with Imagenet 1k.
Partially addresses: #645
TODO: re-upload the models from my branch, and update the URLs