Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow io.write_video to work with video_arrays on different devices #8537

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Allow io.write_video to work with video_arrays on different devices #8537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61994a0
Allow write_video to work with video_arrays on cuda devices
bmmtstb Jul 18, 2024
c08b63f
Merge branch 'main' into main
bmmtstb Jul 23, 2024
bd6f0a4
Merge branch 'main' into main
NicolasHug Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion test/test_io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,10 +255,14 @@ def test_read_video_partially_corrupted_file(self):
assert_equal(video, data)

@pytest.mark.skipif(sys.platform == "win32", reason="temporarily disabled on Windows")
def test_write_video_with_audio(self, tmpdir):
@pytest.mark.parametrize("device", ["cpu", "cuda"])
def test_write_video_with_audio(self, device, tmpdir):
f_name = os.path.join(VIDEO_DIR, "R6llTwEh07w.mp4")
video_tensor, audio_tensor, info = io.read_video(f_name, pts_unit="sec")

video_tensor = video_tensor.to(device)
audio_tensor = audio_tensor.to(device)

out_f_name = os.path.join(tmpdir, "testing.mp4")
io.video.write_video(
out_f_name,
Expand Down
2 changes: 1 addition & 1 deletion torchvision/io/video.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def write_video(
if not torch.jit.is_scripting() and not torch.jit.is_tracing():
_log_api_usage_once(write_video)
_check_av_available()
video_array = torch.as_tensor(video_array, dtype=torch.uint8).numpy()
video_array = torch.as_tensor(video_array, dtype=torch.uint8).numpy(force=True)

# PyAV does not support floating point numbers with decimal point
# and will throw OverflowException in case this is not the case
Expand Down
Loading