Change SBDataset to make it support already-downloaded datasets #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm merging this, but let me know if you disagree. |
|
@fmassa sorry for delay! No problems with the change, lgtm :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, if the user already had downloaded SBD and copied the relevant files somewhere, it wouldn't be possible to use the already-downloaded files, because the structure of the folder was fixed.
This is a breaking change in the sense that the files will need to be downloaded again (or manually moved), but given that this dataset hasn't been in any release yet, I think this is fine.
cc @vfdev-5 who originally added this dataset.