Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic error in check_integrity #871

Merged
merged 3 commits into from
Apr 25, 2019

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Apr 25, 2019

See #869

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I have some minor stylistic comments.

Also, can you add some tests in test_datasets.py for both check_integrity and check_md5?

torchvision/datasets/utils.py Show resolved Hide resolved
torchvision/datasets/utils.py Outdated Show resolved Hide resolved
@pmeier
Copy link
Collaborator Author

pmeier commented Apr 25, 2019

Also, can you add some tests in test_datasets.py for both check_integrity and check_md5?

Sure. Should I push them to this branch or open another PR?

@codecov-io
Copy link

codecov-io commented Apr 25, 2019

Codecov Report

Merging #871 into master will decrease coverage by 0.07%.
The diff coverage is 18.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #871      +/-   ##
==========================================
- Coverage   54.51%   54.44%   -0.08%     
==========================================
  Files          36       36              
  Lines        3320     3328       +8     
  Branches      546      548       +2     
==========================================
+ Hits         1810     1812       +2     
- Misses       1376     1380       +4     
- Partials      134      136       +2
Impacted Files Coverage Δ
torchvision/datasets/utils.py 36.84% <18.18%> (+1.73%) ⬆️
torchvision/datasets/folder.py 74.39% <0%> (-1.61%) ⬇️
torchvision/transforms/functional.py 69.2% <0%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c4e68e...fbfa91f. Read the comment docs.

@soumith soumith merged commit 4785dfa into pytorch:master Apr 25, 2019
@soumith
Copy link
Member

soumith commented Apr 25, 2019

thanks!

@fmassa
Copy link
Member

fmassa commented Apr 25, 2019

@pmeier just send a new PR

@pmeier pmeier deleted the fix_check_integrity branch July 3, 2019 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants