Allow forcing GPU build with FORCE_CUDA=1 #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is convenient to e.g. build with GPU support inside a docker image
Codecov Report
@@ Coverage Diff @@
## master #927 +/- ##
=======================================
Coverage 60.15% 60.15%
=======================================
Files 63 63
Lines 5019 5019
Branches 748 748
=======================================
Hits 3019 3019
- Misses 1795 1796 +1
+ Partials 205 204 -1
Continue to review full report at Codecov.
|
fmassa
approved these changes
May 20, 2019
There was a problem hiding this comment.
LGTM!
And yes, we should probably include documentation for this flag, together with the build instructions for torchvision now that we have custom ops, as OSX requires adding
MACOSX_DEPLOYMENT_TARGET=10.9 CC=clang CXX=clang++ python setup.py build develop
for the build.
@soumith thoughts?
|
Thanks for review @fmassa 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is convenient to e.g. build with GPU support inside a docker image, because GPU is often not available during the docker build, but the image is intended to be used with nvidia-docker. Related previous attempt - #911, reverted in #924 because it breaks the build in some cases.
This PR is similar to facebookresearch/maskrcnn-benchmark#612
I wonder if we should mention anything in the docs about this flag, e.g. at the end of installation section here https://github.com/pytorch/vision#installation ?