remove set tag

pytorch · Nov 13, 2023 · 495f844 · 495f844
1 parent 4acf02d
commit 495f844
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 18 deletions.
diff --git a/torch_xla/csrc/init_python_bindings.cpp b/torch_xla/csrc/init_python_bindings.cpp
@@ -1974,12 +1974,6 @@ void InitXlaModuleBindings(py::module m) {
     xtensor->MarkDynamicDimension(dim);
   });
 
-  m.def("_xla_set_tag", [](const at::Tensor& input, const std::string& tag) {
-    TORCH_LAZY_COUNTER("XlaMarkDynamic", 1);
-    XLATensorPtr xtensor = bridge::GetXlaTensor(input);
-    xtensor->SetTag(tag);
-  });
-
   // -------------Dynamo Integration API Start-------------------------
   /*
    * Return tensor ids and at::tensors for all DeviceData nodes that is needed

diff --git a/torch_xla/csrc/ir.cpp b/torch_xla/csrc/ir.cpp
@@ -178,8 +178,6 @@ std::string XlaNode::ToString() const {
   for (const auto dim : dynamic_dims_) {
     ss << dim;
   }
-  ss << ", "
-     << "tags: " << experimental_tag_;
   return ss.str();
 }
 

diff --git a/torch_xla/csrc/ir.h b/torch_xla/csrc/ir.h
@@ -138,13 +138,12 @@ class XlaNode : public torch::lazy::Node {
 
   std::string ToString() const override;
 
-  void MarkDynamicDimension(uint32_t dim) { dynamic_dims_.push_back(dim); }
-  void SetTag(const std::string& tag) { experimental_tag_ = tag; }
-  const std::string& experimental_tag() const { return experimental_tag_; }
+  void MarkDynamicDimension(uint32_t dim) {
+    dynamic_dims_.push_back(dim);
+  }
   const std::vector<uint32_t>& dynamic_dims() const { return dynamic_dims_; }
 
  protected:
-  std::string experimental_tag_;
   std::vector<uint32_t> dynamic_dims_;
 
  private:

diff --git a/torch_xla/csrc/tensor.cpp b/torch_xla/csrc/tensor.cpp
@@ -899,9 +899,4 @@ void XLATensor::MarkDynamicDimension(uint32_t dim) {
   xla_node->MarkDynamicDimension(dim);
 }
 
-void XLATensor::SetTag(const std::string& tag) {
-  auto* xla_node = dynamic_cast<XlaNode*>(CurrentIrValue().node.get());
-  xla_node->SetTag(tag);
-}
-
 }  // namespace torch_xla
diff --git a/torch_xla/csrc/tensor.h b/torch_xla/csrc/tensor.h
@@ -202,7 +202,6 @@ class XLATensor : public torch::lazy::LazyTensor {
   void SetScalarType(c10::optional<at::ScalarType> logical_element_type);
 
   void MarkDynamicDimension(uint32_t dim);
-  void SetTag(const std::string& tag);
   // We don't use the upstream shape to provide xla::shape.
   runtime::util::MaybeRef<xla::Shape> shape() const;