Add inverse op and test

minor format change
pytorch · Feb 5, 2020 · 86d3c70 · 86d3c70
1 parent b4ec4bb
commit 86d3c70
Show file tree

Hide file tree

Showing 10 changed files with 54 additions and 0 deletions.
diff --git a/scripts/gen.py b/scripts/gen.py
@@ -96,6 +96,7 @@ class ArgTemplate(string.Template):
     'gather_out': FuncOpts(),
     'kthvalue_out': FuncOpts(),
     'index_select_out': FuncOpts(),
+    'inverse_out' : FuncOpts(),
     'log_out': FuncOpts(),
     'masked_select_out': FuncOpts(),
     'nonzero_out': FuncOpts(),

diff --git a/test/cpp/test_aten_xla_tensor.cpp b/test/cpp/test_aten_xla_tensor.cpp
@@ -3624,6 +3624,16 @@ TEST_F(AtenXlaTensorTest, TestIndexSelectRank0) {
   }
 }
 
+TEST_F(AtenXlaTensorTest, TestInverse) {
+  at::Tensor a = at::randn({5, 5}, at::TensorOptions(at::kFloat));
+  at::Tensor b = at::inverse(a);
+  ForEachDevice([&](const Device& device) {
+    at::Tensor xla_a = bridge::CreateXlaTensor(a, device);
+    at::Tensor xla_b = at::inverse(xla_a);
+    AllClose(b, xla_b, /*rtol=*/1e-3, /*atol=*/1e-4);
+  });
+}
+
 TEST_F(AtenXlaTensorTest, TestExpand) {
   torch::Tensor a = torch::rand({3, 4}, torch::TensorOptions(torch::kFloat));
   torch::Tensor b = a.expand({2, 3, 4}, /*implicit=*/false);

diff --git a/torch_xla/csrc/aten_xla_type.cpp b/torch_xla/csrc/aten_xla_type.cpp
@@ -1403,6 +1403,12 @@ at::Tensor AtenXlaType::index_select(const at::Tensor& self, int64_t dim,
       bridge::GetXlaTensor(self), dim, bridge::GetXlaTensor(index)));
 }
 
+at::Tensor AtenXlaType::inverse(const at::Tensor& self) {
+  XLA_FN_COUNTER("xla::");
+  return bridge::AtenFromXlaTensor(
+      XLATensor::inverse(bridge::GetXlaTensor(self)));
+}
+
 at::Tensor AtenXlaType::kl_div(const at::Tensor& self, const at::Tensor& target,
                                int64_t reduction) {
   XLA_FN_COUNTER("xla::");

diff --git a/torch_xla/csrc/aten_xla_type.h b/torch_xla/csrc/aten_xla_type.h
@@ -439,6 +439,8 @@ class AtenXlaType {
   static at::Tensor index_select(const at::Tensor& self, int64_t dim,
                                  const at::Tensor& index);
 
+  static at::Tensor inverse(const at::Tensor& self);
+
   static at::Tensor kl_div(const at::Tensor& self, const at::Tensor& target,
                            int64_t reduction);
 

diff --git a/torch_xla/csrc/matrix.cpp b/torch_xla/csrc/matrix.cpp
@@ -2,6 +2,7 @@
 
 #include "tensorflow/compiler/xla/client/lib/constants.h"
 #include "tensorflow/compiler/xla/client/lib/matrix.h"
+#include "tensorflow/compiler/xla/client/lib/qr.h"
 #include "tensorflow/compiler/xla/shape_util.h"
 #include "tensorflow/compiler/xla/util.h"
 #include "torch_xla/csrc/convert_ops.h"
@@ -126,4 +127,17 @@ xla::XlaOp BuildDiagonalViewUpdate(xla::XlaOp target, xla::XlaOp input,
   return result;
 }
 
+xla::XlaOp BuildInverse(xla::XlaOp input) {
+  xla::QRDecompositionResult qr_result =
+      xla::QRDecomposition(input, /*full_matrices=*/false,
+                           XlaHelpers::mat_mul_precision())
+          .ValueOrDie();
+  return xla::TriangularSolve(qr_result.r,
+                              xla::TransposeInMinorDims(qr_result.q),
+                              /*left_side=*/true,
+                              /*lower=*/false, /*unit_diagonal=*/false,
+                              /*transpose_a=*/
+                              xla::TriangularSolveOptions::NO_TRANSPOSE);
+}
+
 }  // namespace torch_xla
diff --git a/torch_xla/csrc/matrix.h b/torch_xla/csrc/matrix.h
@@ -15,4 +15,6 @@ xla::XlaOp BuildDiagonalViewUpdate(xla::XlaOp target, xla::XlaOp input,
                                    xla::int64 offset, xla::int64 dim1,
                                    xla::int64 dim2);
 
+xla::XlaOp BuildInverse(xla::XlaOp input);
+
 }  // namespace torch_xla
diff --git a/torch_xla/csrc/ops/ops.cpp b/torch_xla/csrc/ops/ops.cpp
@@ -13,6 +13,7 @@
 #include "torch_xla/csrc/elementwise.h"
 #include "torch_xla/csrc/helpers.h"
 #include "torch_xla/csrc/lowering_context.h"
+#include "torch_xla/csrc/matrix.h"
 #include "torch_xla/csrc/nll_loss.h"
 #include "torch_xla/csrc/ops/arithmetic_ir_ops.h"
 #include "torch_xla/csrc/ops/constant.h"
@@ -633,6 +634,16 @@ NodePtr LogDet(const Value& input) {
                    std::move(lower_fn));
 }
 
+NodePtr Inverse(const Value& input) {
+  auto lower_fn = [](const Node& node, LoweringContext* loctx) -> XlaOpVector {
+    xla::XlaOp xla_input = loctx->GetOutputOp(node.operand(0));
+    xla::XlaOp result = BuildInverse(xla_input);
+    return node.ReturnOp(result, loctx);
+  };
+  return GenericOp(OpKind(at::aten::inverse), {input}, input.shape(),
+                   std::move(lower_fn));
+}
+
 }  // namespace ops
 }  // namespace ir
 }  // namespace torch_xla
diff --git a/torch_xla/csrc/ops/ops.h b/torch_xla/csrc/ops/ops.h
@@ -194,6 +194,8 @@ NodePtr Take(const Value& input, const Value& index);
 
 NodePtr LogDet(const Value& input);
 
+NodePtr Inverse(const Value& input);
+
 }  // namespace ops
 }  // namespace ir
 }  // namespace torch_xla
diff --git a/torch_xla/csrc/tensor.h b/torch_xla/csrc/tensor.h
@@ -542,6 +542,8 @@ class XLATensor {
   static XLATensor index_select(const XLATensor& input, xla::int64 dim,
                                 const XLATensor& index);
 
+  static XLATensor inverse(const XLATensor& input);
+
   static XLATensor kl_div_backward(const XLATensor& grad_output,
                                    const XLATensor& input,
                                    const XLATensor& target,

diff --git a/torch_xla/csrc/tensor_methods.cpp b/torch_xla/csrc/tensor_methods.cpp
@@ -1249,6 +1249,10 @@ XLATensor XLATensor::index_select(const XLATensor& input, xla::int64 dim,
       index_value));
 }
 
+XLATensor XLATensor::inverse(const XLATensor& input) {
+  return input.CreateFrom(ir::ops::Inverse(input.GetIrValue()));
+}
+
 XLATensor XLATensor::kl_div_backward(const XLATensor& grad_output,
                                      const XLATensor& input,
                                      const XLATensor& target,