Skip to content

Commit

Permalink
Allow benchmark runner config: openxla for inference runs. (#5939)
Browse files Browse the repository at this point in the history
* Allow openxla for eval.

* Update readme.

* Revert `openxla_eval` rule.
  • Loading branch information
ysiraichi authored and golechwierowicz committed Jan 12, 2024
1 parent 2e5fe00 commit 8a04f83
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
3 changes: 2 additions & 1 deletion benchmarks/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,10 @@ python xla/benchmarks/experiment_runner.py \
You can change the flags to add the configurations you are interested in. The
`experiment_runner.py` will expand the options to all supported configurations.
For example, in the case above, it will consider all the possible combinations
among the flags `--dynamo`, `--xla`, and `--test`, 4 of which are supported:
among the flags `--dynamo`, `--xla`, and `--test`, 5 of which are supported:

- `dynamo=openxla_eval`, `xla=PJRT`, `test=eval`
- `dynamo=openxla`, `xla=PJRT`, `test=eval`
- `dynamo=openxla`, `xla=PJRT`, `test=train`
- `dynamo=inductor`, `xla=None`, `test=eval`
- `dynamo=inductor`, `xla=None`, `test=train`
Expand Down
3 changes: 1 addition & 2 deletions benchmarks/benchmark_experiment.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,7 @@ def is_available(self, experiment_config):
if experiment_config["dynamo"] == "openxla_eval" and not (
experiment_config["xla"] and experiment_config["test"] == "eval"):
return False
if experiment_config["dynamo"] == "openxla" and not (
experiment_config["xla"] and experiment_config["test"] == "train"):
if experiment_config["dynamo"] == "openxla" and not experiment_config["xla"]:
return False
if (experiment_config["xla"] and
not is_xla_device_available(experiment_config["accelerator"].upper())):
Expand Down
2 changes: 1 addition & 1 deletion benchmarks/experiment_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,7 @@ def parse_args(args=None):
"--collect-full-output",
action="store_true",
help="""Whether to collect full output for training. Set this to true if we
want to verify the numerical correctness of graidents. But that may
want to verify the numerical correctness of gradients. But that may
cause time measurement not accurate""",
)

Expand Down

0 comments on commit 8a04f83

Please sign in to comment.