Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move distributed checkpointing to a subdirectory of experimental #5656

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

jonb377
Copy link
Collaborator

@jonb377 jonb377 commented Sep 29, 2023

The number of checkpointing-related files is growing in the experimental folder, so this change moves them to a dedicated subdirectory.

@jonb377 jonb377 force-pushed the jonbolin-chkpt branch 2 times, most recently from c060b6e to 5be8e65 Compare October 2, 2023 23:42
Copy link
Collaborator

@alanwaketan alanwaketan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as the helpers are not exposed to the users.

@jonb377
Copy link
Collaborator Author

jonb377 commented Oct 3, 2023

LGTM as long as the helpers are not exposed to the users.

@alanwaketan Is keeping the helpers file private sufficient? Like _helpers.py

@alanwaketan
Copy link
Collaborator

LGTM as long as the helpers are not exposed to the users.

@alanwaketan Is keeping the helpers file private sufficient? Like _helpers.py

I think so.

@jonb377
Copy link
Collaborator Author

jonb377 commented Oct 3, 2023

Rebased, I'll merge after TPU CI passes. Thanks for the review @alanwaketan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants