-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move distributed checkpointing to a subdirectory of experimental #5656
Conversation
c060b6e
to
5be8e65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as the helpers are not exposed to the users.
@alanwaketan Is keeping the helpers file private sufficient? Like |
I think so. |
5be8e65
to
ba34860
Compare
Rebased, I'll merge after TPU CI passes. Thanks for the review @alanwaketan! |
The number of checkpointing-related files is growing in the experimental folder, so this change moves them to a dedicated subdirectory.