Initial commit for CheckpointManager #5678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functionality here doesn't depend on it. For distributed checkpointing, the main use case of that PR is to discover the master IP for the CPU process group. The stronger use case is going to be distributed data loading. I'll sync with Yeounoh if we're OK to land it now, otherwise I can convert to draft until it's needed. |
alanwaketan
approved these changes
Oct 6, 2023
jonb377
force-pushed
the
jonbolin/chkpt-manager
branch
from
5a48879
to
46f9706
Compare
jonb377
commented
Oct 9, 2023
Comment on lines
+72
to
+78
| async_queue_size: The size of the execution queue which processes async | ||
| checkpoints. This should be a small value to ensure training doesn't | ||
| get too far ahead of the last finished checkpoint, but increasing | ||
| the value to 2 can unblock training when there are transient | ||
| network issues which slow down the active checkpoint. | ||
| Default: 1, which only allows a single async checkpoint to be | ||
| pending at a time. |
qihqi
pushed a commit
that referenced
this pull request
Oct 10, 2023
* Initial commit for CheckpointManager * Update documentation for async * Fix typo
zpcore
pushed a commit
that referenced
this pull request
Oct 19, 2023
* Initial commit for CheckpointManager * Update documentation for async * Fix typo
ghpvnist
pushed a commit
to ghpvnist/xla
that referenced
this pull request
Oct 31, 2023
* Initial commit for CheckpointManager * Update documentation for async * Fix typo
mbzomowski
pushed a commit
to mbzomowski-test-org/xla
that referenced
this pull request
Nov 16, 2023
* Initial commit for CheckpointManager * Update documentation for async * Fix typo
chunnienc
pushed a commit
to chunnienc/xla
that referenced
this pull request
Dec 14, 2023
* Initial commit for CheckpointManager * Update documentation for async * Fix typo
golechwierowicz
pushed a commit
that referenced
this pull request
Jan 12, 2024
* Initial commit for CheckpointManager * Update documentation for async * Fix typo
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
* Initial commit for CheckpointManager * Update documentation for async * Fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the boilerplate code and documentation for CheckpointManager, a higher-level wrapper which interfaces with the
torch.distributed.checkpointAPIs. CheckpointManager will provide some key functionality: