Fix masked_fill broadcasting.
#5688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wonjoolee95 can you take a look? |
wonjoolee95
approved these changes
Oct 10, 2023
vanbasten23
reviewed
Oct 11, 2023
zpcore
pushed a commit
that referenced
this pull request
Oct 19, 2023
ghpvnist
pushed a commit
to ghpvnist/xla
that referenced
this pull request
Oct 31, 2023
mbzomowski
pushed a commit
to mbzomowski-test-org/xla
that referenced
this pull request
Nov 16, 2023
chunnienc
pushed a commit
to chunnienc/xla
that referenced
this pull request
Dec 14, 2023
golechwierowicz
pushed a commit
that referenced
this pull request
Jan 12, 2024
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes tensor broadcasting for
masked_fill(input, mask, scalar). Specifically, when they have the same rank.Problem: when both
inputandmaskwere same rank tensors, say[2, 2]and[2, 1]respectively, we always expanded theinput.Solution: inlined part of the code of
XlaHelpers::PromoteShapes(without the type comparison).