Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable xla backend for SPMD #5690

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Disable xla backend for SPMD #5690

merged 3 commits into from
Oct 11, 2023

Conversation

jonb377
Copy link
Collaborator

@jonb377 jonb377 commented Oct 9, 2023

We should not allow using the xla backend with SPMD mode execution. Conceptually, SPMD has a single replica, and users should not need to directly manage collectives on the devices since the compiler will determine where the collectives should be.

Copy link
Collaborator

@alanwaketan alanwaketan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do you want to add a test case?

Copy link
Contributor

@yeounoh yeounoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,, thx

@jonb377 jonb377 merged commit 5db42bc into master Oct 11, 2023
18 checks passed
@jonb377 jonb377 deleted the jonbolin/pg branch October 11, 2023 01:13
zpcore pushed a commit that referenced this pull request Oct 19, 2023
* Disable xla backend for SPMD

* Add test

* yapf
ghpvnist pushed a commit to ghpvnist/xla that referenced this pull request Oct 31, 2023
* Disable xla backend for SPMD

* Add test

* yapf
mbzomowski pushed a commit to mbzomowski-test-org/xla that referenced this pull request Nov 16, 2023
* Disable xla backend for SPMD

* Add test

* yapf
chunnienc pushed a commit to chunnienc/xla that referenced this pull request Dec 14, 2023
* Disable xla backend for SPMD

* Add test

* yapf
golechwierowicz pushed a commit that referenced this pull request Jan 12, 2024
* Disable xla backend for SPMD

* Add test

* yapf
bhavya01 pushed a commit that referenced this pull request Apr 22, 2024
* Disable xla backend for SPMD

* Add test

* yapf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants