pass bundle object to make_tf_function #5708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riables as args to the XlaCallModule op.
qihqi
approved these changes
Oct 16, 2023
zpcore
pushed a commit
that referenced
this pull request
Oct 19, 2023
* Pass bundle object to make_tf_function, so that it will include tf.variables as args to the XlaCallModule op. * fix format
ghpvnist
pushed a commit
to ghpvnist/xla
that referenced
this pull request
Oct 31, 2023
* Pass bundle object to make_tf_function, so that it will include tf.variables as args to the XlaCallModule op. * fix format
mbzomowski
pushed a commit
to mbzomowski-test-org/xla
that referenced
this pull request
Nov 16, 2023
* Pass bundle object to make_tf_function, so that it will include tf.variables as args to the XlaCallModule op. * fix format
chunnienc
pushed a commit
to chunnienc/xla
that referenced
this pull request
Dec 14, 2023
* Pass bundle object to make_tf_function, so that it will include tf.variables as args to the XlaCallModule op. * fix format
golechwierowicz
pushed a commit
that referenced
this pull request
Jan 12, 2024
* Pass bundle object to make_tf_function, so that it will include tf.variables as args to the XlaCallModule op. * fix format
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
* Pass bundle object to make_tf_function, so that it will include tf.variables as args to the XlaCallModule op. * fix format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In tf_saved_model_integration, we need to pass the bundle object created within
save_stablehlo_graph_as_tf, to the make_tf_function, which then use the tf.Varaibles in the bundle to define input args for xla call module. In this way, the weights won't be inlined in the GraphDef, and the resulting graph size will significantly reduce.