Add tooling to explain why a graph execution happens #5723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanbasten23
reviewed
Oct 25, 2023
| << "======================================================================" | ||
| "==========" | ||
| << "\n"; | ||
| if (frames[0].function == "mark_step") { |
There was a problem hiding this comment.
Wondering if it worths logging frames[0].function; for the cases other than mark_step.
There was a problem hiding this comment.
yea I want to expand this a bit later to cover most of the common cases of the execution.
vanbasten23
approved these changes
Oct 25, 2023
|
I need to add some test, will try to do that this week |
JackCaoG
force-pushed
the
JackCaoG/debug_tool
branch
from
f897811
to
6dd0623
Compare
JackCaoG
changed the title
|
This should be ready for review. |
|
I will update troubleshotting in a separate pr. |
|
@will-cromar Can I get a review for this one? |
alanwaketan
reviewed
Oct 31, 2023
|
dumped graph is in a separate file and it always dump the HLO or IR which can be huge. The idea is that we should dump something more concise and provide some explanation on what is happening, this can be interleave with the debugging message user added to their model code. |
|
@carmocca FYI, this is a WIP I will add more to this tooling. |
mbzomowski
pushed a commit
to mbzomowski-test-org/xla
that referenced
this pull request
Nov 16, 2023
* Initial commit for debugging tool * minor format tweak * Only master process should print the execution frame info * add execution cause * handle dynamo and everything else * add test * linter * add test to the script
ManfeiBai
pushed a commit
that referenced
this pull request
Nov 29, 2023
* Initial commit for debugging tool * minor format tweak * Only master process should print the execution frame info * add execution cause * handle dynamo and everything else * add test * linter * add test to the script
ManfeiBai
pushed a commit
that referenced
this pull request
Nov 29, 2023
* Initial commit for debugging tool * minor format tweak * Only master process should print the execution frame info * add execution cause * handle dynamo and everything else * add test * linter * add test to the script
chunnienc
pushed a commit
to chunnienc/xla
that referenced
this pull request
Dec 14, 2023
* Initial commit for debugging tool * minor format tweak * Only master process should print the execution frame info * add execution cause * handle dynamo and everything else * add test * linter * add test to the script
golechwierowicz
pushed a commit
that referenced
this pull request
Jan 12, 2024
* Initial commit for debugging tool * minor format tweak * Only master process should print the execution frame info * add execution cause * handle dynamo and everything else * add test * linter * add test to the script
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
* Initial commit for debugging tool * minor format tweak * Only master process should print the execution frame info * add execution cause * handle dynamo and everything else * add test * linter * add test to the script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI @Liyang90 @AlexWertheim
example output