Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add op lowering for _prelu_kernel_backward #5724

Merged
merged 2 commits into from
Oct 24, 2023
Merged

add op lowering for _prelu_kernel_backward #5724

merged 2 commits into from
Oct 24, 2023

Conversation

zpcore
Copy link
Collaborator

@zpcore zpcore commented Oct 24, 2023

Fix #5695

Manual lowering for op _prelu_kernel_backward, based on https://github.com/pytorch/pytorch/blob/4b324a8717e54faf1664248c3347633f4ff1e428/aten/src/ATen/native/cpu/Activation.cpp#L1419C1-L1430C1.

The op function signature in auto generated file XLANativeunctions.h is:

static ::std::tuple<at::Tensor,at::Tensor> _prelu_kernel_backward(const at::Tensor & grad_output, const at::Tensor & self, const at::Tensor & weight);

@zpcore
Copy link
Collaborator Author

zpcore commented Oct 24, 2023

Actually I am not quite understand why _prelu_kernel_backward was not decomposed into where based on the code here. Can anyone explain the reason?

@zpcore zpcore self-assigned this Oct 24, 2023
@zpcore zpcore merged commit d28b30d into master Oct 24, 2023
18 checks passed
ghpvnist pushed a commit to ghpvnist/xla that referenced this pull request Oct 31, 2023
* add op lowering for _prelu_kernel_backward

* remove comment line
mbzomowski pushed a commit to mbzomowski-test-org/xla that referenced this pull request Nov 16, 2023
* add op lowering for _prelu_kernel_backward

* remove comment line
chunnienc pushed a commit to chunnienc/xla that referenced this pull request Dec 14, 2023
* add op lowering for _prelu_kernel_backward

* remove comment line
golechwierowicz pushed a commit that referenced this pull request Jan 12, 2024
* add op lowering for _prelu_kernel_backward

* remove comment line
bhavya01 pushed a commit that referenced this pull request Apr 22, 2024
* add op lowering for _prelu_kernel_backward

* remove comment line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OP lowering for _prelu_kernel_backward
2 participants