Make the git version appears in pip #5728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This change makes the git version appears in pip by default. For any official release, we should turn that off by setting VERSIONED_XLA_BUILD=0. Here is how it looks like: torch 2.2.0a0+git6ac8451 torch-xla 2.2.0+git43cd6b5 Test Plan: Manual.
JackCaoG
reviewed
Oct 24, 2023
JackCaoG
approved these changes
Oct 24, 2023
will-cromar
reviewed
Oct 24, 2023
setup.py
Outdated
| @@ -101,9 +101,9 @@ def get_git_head_sha(base_dir): | |||
|
|
|||
| def get_build_version(xla_git_sha): | |||
| version = os.getenv('TORCH_XLA_VERSION', '2.2.0') | |||
| if _check_env_flag('VERSIONED_XLA_BUILD', default='0'): | |||
| if _check_env_flag('VERSIONED_XLA_BUILD', default='1'): | |||
There was a problem hiding this comment.
Since this variable looks otherwise unused, what do you think of changing the name to be more explicit, e.g. APPEND_GIT_SHA?
"VERSIONED_XLA_BUILD" makes me think of releases, which is the opposite of what we want.
There was a problem hiding this comment.
Sure, why not.
alanwaketan
requested review from
yeounoh,
mateuszlewko and
stgpetrovic
as code owners
|
@will-cromar Can you take another look? |
will-cromar
approved these changes
Oct 24, 2023
| @@ -101,9 +101,9 @@ def get_git_head_sha(base_dir): | |||
|
|
|||
| def get_build_version(xla_git_sha): | |||
| version = os.getenv('TORCH_XLA_VERSION', '2.2.0') | |||
| if _check_env_flag('VERSIONED_XLA_BUILD', default='0'): | |||
| if _check_env_flag('GIT_VERSIONED_XLA_BUILD', default='TRUE'): | |||
There was a problem hiding this comment.
Do you know if nightly_release this is going to be TRUE or true?
There was a problem hiding this comment.
It doesn't matter. _check_env_flag will convert everything to upper case.
|
Thanks all for the review. Pending CI now. |
ghpvnist
pushed a commit
to ghpvnist/xla
that referenced
this pull request
Oct 31, 2023
Summary: This change makes the git version appears in pip by default. For any official release, we should turn that off by setting VERSIONED_XLA_BUILD=0. Here is how it looks like: torch 2.2.0a0+git6ac8451 torch-xla 2.2.0+git43cd6b5 Test Plan: Manual.
mbzomowski
pushed a commit
to mbzomowski-test-org/xla
that referenced
this pull request
Nov 16, 2023
Summary: This change makes the git version appears in pip by default. For any official release, we should turn that off by setting VERSIONED_XLA_BUILD=0. Here is how it looks like: torch 2.2.0a0+git6ac8451 torch-xla 2.2.0+git43cd6b5 Test Plan: Manual.
chunnienc
pushed a commit
to chunnienc/xla
that referenced
this pull request
Dec 14, 2023
Summary: This change makes the git version appears in pip by default. For any official release, we should turn that off by setting VERSIONED_XLA_BUILD=0. Here is how it looks like: torch 2.2.0a0+git6ac8451 torch-xla 2.2.0+git43cd6b5 Test Plan: Manual.
golechwierowicz
pushed a commit
that referenced
this pull request
Jan 12, 2024
Summary: This change makes the git version appears in pip by default. For any official release, we should turn that off by setting VERSIONED_XLA_BUILD=0. Here is how it looks like: torch 2.2.0a0+git6ac8451 torch-xla 2.2.0+git43cd6b5 Test Plan: Manual.
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
Summary: This change makes the git version appears in pip by default. For any official release, we should turn that off by setting VERSIONED_XLA_BUILD=0. Here is how it looks like: torch 2.2.0a0+git6ac8451 torch-xla 2.2.0+git43cd6b5 Test Plan: Manual.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change makes the git version appears in pip by default. For any official release, we should turn that off by setting VERSIONED_XLA_BUILD=0.
Here is how it looks like:
torch 2.2.0a0+git6ac8451
torch-xla 2.2.0+git43cd6b5
Test Plan:
Manual.