Mangle root scope TF variable name during tf.saved_model export #5738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qihqi
approved these changes
Oct 26, 2023
mbzomowski
pushed a commit
to mbzomowski-test-org/xla
that referenced
this pull request
Nov 16, 2023
…rch#5738) * mangle tf root scope name
ManfeiBai
pushed a commit
that referenced
this pull request
Nov 29, 2023
* mangle tf root scope name
ManfeiBai
pushed a commit
that referenced
this pull request
Nov 29, 2023
* mangle tf root scope name
chunnienc
pushed a commit
to chunnienc/xla
that referenced
this pull request
Dec 14, 2023
…rch#5738) * mangle tf root scope name
golechwierowicz
pushed a commit
that referenced
this pull request
Jan 12, 2024
* mangle tf root scope name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following error is hit during tf.saved_model export:
The reason is TF has more restricted constrain on the variable names at root scope. The variable name is from state_dict of ExportedProgram, which doesn't have such naming constrain.
Root scope name constrain: [A-Za-z0-9.][A-Za-z0-9_.\-/]*
Non-root scope name constrain: [A-Za-z0-9_.\-/]*
code ref in TF
Name mangling: Add 'k' if the variable name starts with '_\-/'
Testing: Manually test the model failed to be exported to tf.saved_model