Update artifacts.auto.tfvars for r2.1 with py39/310 for tpu/gpu #5741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManfeiBai
requested review from
will-cromar,
JackCaoG,
yeounoh,
mateuszlewko and
stgpetrovic
as code owners
ManfeiBai
force-pushed
the
ManfeiBai-patch-38
branch
from
c3a7fca
to
bc32ce0
Compare
will-cromar
reviewed
Oct 27, 2023
| bundle_libtpu = "1" | ||
| }, | ||
| { | ||
| git_tag = "v2.1.0" |
There was a problem hiding this comment.
I added this build in #5744
| @@ -65,6 +66,22 @@ versioned_builds = [ | |||
| python_version = "3.9" | |||
| bundle_libtpu = "0" | |||
| }, | |||
| { | |||
| git_tag = "v2.1.0" | |||
There was a problem hiding this comment.
Who is the 3.9 build with libtpu for? The bundled build is primarily for Kaggle, who uses Python 3.10
| git_tag = "v2.1.0" | ||
| pytorch_git_rev = "v2.1.0" | ||
| package_version = "2.1.0" | ||
| accelerator = "cuda" |
There was a problem hiding this comment.
I think we only need the CUDA 12.1 build, right? That's the one that will work with the default torch wheel IIRC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.