Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove master IP discovery test for MP #5748

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Remove master IP discovery test for MP #5748

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions test/pjrt/test_runtime_tpu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,13 +238,6 @@ def test_execute_time_metric(self):
f"Expected exectue time of {i} to take more than "
f"{expected_time_seconds} seconds, got {v / 1e9} seconds")

@mock.patch('torch_xla._internal.tpu.get_worker_ips')
def test_master_ip_discovery(self, patched_get_worker_ips):
# A basic test to verify the non-SPMD codepath returns the correct IP. Two
# IPs are needed to avoid the short-circuit return of localhost.
patched_get_worker_ips.return_value = ['10.0.0.1', '10.0.0.2']
self.assertTrue(xr.get_master_ip(), '10.0.0.1')


if __name__ == '__main__':
absltest.main()