Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _unsafe_index implementation. #5769

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

ysiraichi
Copy link
Collaborator

This PR partially reverts #5707, except for its Python-level test.

Due to the recent merge of pytorch/pytorch#111795, which turned _unsafe_index dispatch into CompositeExplicitAutograd, the code introduced in the previous PR is not needed anymore.

@ysiraichi ysiraichi requested a review from JackCaoG November 5, 2023 13:21
Copy link
Collaborator

@JackCaoG JackCaoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ysiraichi ysiraichi merged commit 28c277f into pytorch:master Nov 6, 2023
17 checks passed
mbzomowski pushed a commit to mbzomowski-test-org/xla that referenced this pull request Nov 16, 2023
ManfeiBai pushed a commit that referenced this pull request Nov 29, 2023
ManfeiBai pushed a commit that referenced this pull request Nov 29, 2023
@lezcano lezcano added the xla:gpu label Dec 1, 2023
chunnienc pushed a commit to chunnienc/xla that referenced this pull request Dec 14, 2023
bhavya01 pushed a commit that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants