Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower AtenFull op #5781

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Lower AtenFull op #5781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21f7148
lower full
danielvegamyhre Nov 8, 2023
3bb3b93
update test for full op
danielvegamyhre Nov 8, 2023
94fb2e3
formatting
danielvegamyhre Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions codegen/xla_native_functions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@ supported:
- floor_divide
- fmod.Scalar
- fmod.Tensor
- full
- gather
- gelu
- gelu_backward
Expand Down
3 changes: 1 addition & 2 deletions test/cpp/test_aten_xla_tensor_1.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,7 @@ TEST_F(AtenXlaTensorTest, TestFull) {
});

ExpectCounterNotChanged("aten::.*", cpp_test::GetIgnoredCounters());
ExpectCounterChanged("xla::empty", cpp_test::GetIgnoredCounters());
ExpectCounterChanged("xla::fill_", cpp_test::GetIgnoredCounters());
ExpectCounterChanged("xla::full", cpp_test::GetIgnoredCounters());
}

TEST_F(AtenXlaTensorTest, TestFullLike) {
Expand Down
18 changes: 18 additions & 0 deletions torch_xla/csrc/aten_xla_type.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1331,6 +1331,24 @@ at::Tensor XLANativeFunctions::fmod(const at::Tensor& self,
});
}

at::Tensor XLANativeFunctions::full(at::IntArrayRef size,
const at::Scalar& fill_value,
c10::optional<at::ScalarType> dtype,
c10::optional<at::Layout> layout,
c10::optional<at::Device> device,
c10::optional<bool> pin_memory) {
TORCH_LAZY_FN_COUNTER("xla::");
// Fall back to CPU if layout or pin_memory are not default
if (layout.value_or(at::Layout::Strided) != at::Layout::Strided ||
pin_memory.value_or(false)) {
return at::native::call_fallback_fn<&xla_cpu_fallback, ATEN_OP(full)>::call(
size, fill_value, dtype, layout, device, pin_memory);
}
return bridge::AtenFromXlaTensor(tensor_methods::full(
absl::Span<const int64_t>(size), fill_value,
GetXlaDeviceOrCurrent(device), at::dtype_or_default(dtype)));
}

at::Tensor XLANativeFunctions::gather(const at::Tensor& self, int64_t dim,
const at::Tensor& index,
bool /* sparse_grad */) {
Expand Down