Sync xla_args before computation.
#5823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackCaoG
reviewed
Nov 20, 2023
| # value reference before actually computing it. | ||
| for a in xla_args: | ||
| if isinstance(a, torch.Tensor) and torch._is_functional_tensor(a): | ||
| torch._functionalize_sync(a) |
There was a problem hiding this comment.
first time learnt this api.. interesting.
JackCaoG
approved these changes
Nov 20, 2023
zpcore
pushed a commit
that referenced
this pull request
Nov 21, 2023
lsy323
pushed a commit
to lsy323/xla
that referenced
this pull request
Nov 28, 2023
* Sync `xla_args` before actually computing them. * Only sync `FunctionalTensorWrapper` tensors.
chunnienc
pushed a commit
to chunnienc/xla
that referenced
this pull request
Dec 14, 2023
* Sync `xla_args` before actually computing them. * Only sync `FunctionalTensorWrapper` tensors.
golechwierowicz
pushed a commit
that referenced
this pull request
Jan 12, 2024
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #5746
This PR synchronizes
FunctionalTensorWrapperobjects, before actually computing them. As a result,_clear_pending_irsdoesn't delete the computed tensor anymore.