Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update artifacts.auto.tfvars for 2.2 release #5908

Merged
merged 4 commits into from
Dec 5, 2023
Merged

Update artifacts.auto.tfvars for 2.2 release #5908

merged 4 commits into from
Dec 5, 2023

Conversation

zpcore
Copy link
Collaborator

@zpcore zpcore commented Nov 22, 2023

Add the 2.2 release build similar to 2.1. We will trigger the 2.2 wheel build for xl-ml test. Refer to 2.1 release PR

Tag for 2.2 has also been added -- https://github.com/pytorch/xla/tags.

@zpcore
Copy link
Collaborator Author

zpcore commented Nov 22, 2023

I am not sure if we still need package_version = "2.2.0+xrt".

Copy link
Collaborator

@lsy323 lsy323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lsy323 lsy323 removed the request for review from wonjoolee95 November 22, 2023 18:12
@lsy323 lsy323 changed the title add release build for v2.2 for xl-ml test Update artifacts.auto.tfvars for 2.2 release Nov 22, 2023
pytorch_git_rev = "v2.2.0"
package_version = "2.2.0",
accelerator = "cuda"
cuda_version = "12.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which CUDA version are we targeting? Should we just pick the same CUDA version torch will use in their default wheel?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we leave 11.8 and 12.1 here?

Copy link
Collaborator

@lsy323 lsy323 Nov 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found PyTorch only has cuda 11.8 and 12.1 support. cc @vanbasten23, to double check on the needs on cuda 12.0 whl

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lsy323 , do we still need CUDA 11.8 for 2.2 release?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @will-cromar, thanks, do we know how to confirm the CUDA version torch will use in their default wheel? would they mention in the blog related to 2.2 release?

since there were many PRs to add specific CUDA version to 2.1 release like #5683, so there might be some requirements to build 2.2 wheel with these CUDA versions. And if build failed, we could catch the failure early too

For resources, do we want to delete triggers for 2.1 to limit the resource used for release here?

@@ -58,6 +58,46 @@ xrt_versioned_builds = [
# Built on push to specific tag.
versioned_builds = [
# Remove libtpu from PyPI builds
{
git_tag = "v2.2.0"
pytorch_git_rev = "v2.2.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, PyTorch doesn't apply the v2.2.0 tag until the final release. They'll have v2.2.0rc0, v2.2.0rc1, etc. I actually suggest we do the same for this release rather than updating the v2.2.0 tag multiple times.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you elaborate more about the solution? Should we add v2.2.0rc0, v2.2.0rc1 build etc. here in advance?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, Will

Hi, @zpcore, FYI, since we want to add trigger for 2.2.0 wheel to test in xl-ml-dashboard, and we won't catch pytorch_git_rev tag v2.2.0 until PyTorch 2.2 release from PyTorch, and we also won't catch any other tag like v2.2.0rc0/v2.2.0rc1 until PyTorch 2.2.0 branch cut date, we could merge this PR now but the trigger could build wheel successfully until they catch the tag

So for wheel on xl-ml-dashboard, let's use nightly wheel of torch and torch_xla until branch cut date

cc @lsy323

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you elaborate more about the solution? Should we add v2.2.0rc0, v2.2.0rc1 build etc. here in advance?

let's modify git_tag and pytorch_git_rev to "v2.2.0rc0" in this PR, we would modify again once PyTorch has other wheels built

cc @will-cromar, would you mind help to confirm it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we have removed pytorch_git_rev.

Copy link
Collaborator

@ManfeiBai ManfeiBai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

python_version = "3.10"
pytorch_git_rev = "v2.1.0"
package_version = "2.1.0+xrt"
git_tag = "v2.2.0-rc1"
Copy link
Collaborator

@ManfeiBai ManfeiBai Nov 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @zpcore, thanks for the update, not sure how PyTorch rag 2.2 at branch cut day, in 2.1 release, PyTorch's wheel version is 2.1.0-rc0 at the branch cut day; if we want to catch and start testing 2.2 release from branch cut day, do we want to use v2.2.0-rc0?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ManfeiBai , I checked the pytorch repo but didn't find tag end with -rc0. Can you help double check if we should start from -rc0? They may delete it after the release. Thanks,

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming this, @zpcore, you are right, I didn't find rc0, we could start from -rc1 based on 2.1.0 release history

Copy link
Collaborator

@ManfeiBai ManfeiBai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

python_version = "3.10"
pytorch_git_rev = "v2.1.0"
package_version = "2.1.0+xrt"
git_tag = "v2.2.0-rc1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming this, @zpcore, you are right, I didn't find rc0, we could start from -rc1 based on 2.1.0 release history

Comment on lines +147 to +153
{
git_tag = "v2.2.0-rc1"
package_version = "2.2.0-rc1"
accelerator = "cuda"
cuda_version = "11.8"
python_version = "3.10"
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vanbasten23 do we need this?

@zpcore zpcore merged commit 51df39f into master Dec 5, 2023
18 checks passed
ManfeiBai pushed a commit to ManfeiBai/PyTorchXLA that referenced this pull request Dec 8, 2023
* add release build for v2.2 for xl-ml test

* remove 2.2 xrt build

* update release tag name

* update package version name
chunnienc pushed a commit to chunnienc/xla that referenced this pull request Dec 14, 2023
* add release build for v2.2 for xl-ml test

* remove 2.2 xrt build

* update release tag name

* update package version name
golechwierowicz pushed a commit that referenced this pull request Jan 12, 2024
* add release build for v2.2 for xl-ml test

* remove 2.2 xrt build

* update release tag name

* update package version name
bhavya01 pushed a commit that referenced this pull request Apr 22, 2024
* add release build for v2.2 for xl-ml test

* remove 2.2 xrt build

* update release tag name

* update package version name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants