Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix TypeError issue #5927

Closed
wants to merge 1 commit into from
Closed

fix TypeError issue #5927

wants to merge 1 commit into from

Conversation

zpcore
Copy link
Collaborator

@zpcore zpcore commented Nov 28, 2023

No description provided.

ManfeiBai
ManfeiBai reviewed Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@ManfeiBai ManfeiBai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's wait for the CI results

@zpcore
Copy link
Collaborator Author

zpcore commented Nov 28, 2023

They just pushed the fix for the typing issue in #5921. Let's drop this PR.

@zpcore zpcore closed this Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManfeiBai ManfeiBai ManfeiBai left review comments

@frgossen frgossen Awaiting requested review from frgossen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zpcore @ManfeiBai