Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test_result_analyzer.py to the test directory. #6130

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

ysiraichi
Copy link
Collaborator

This PR moves the tests introduced in #6067 to the test infrastructure introduced in #6043.

@cota
Copy link
Collaborator

cota commented Dec 13, 2023

Looks like we need to land #6137 first, otherwise this will break CI.

@cota
Copy link
Collaborator

cota commented Dec 13, 2023

Please rebase onto master (fixing conflicts and picking up the pandas change). Hopefully it will pass CI.

@ysiraichi ysiraichi force-pushed the ysiraichi/move-result-analyzer-tests branch from 7f874ea to 181f91d Compare December 13, 2023 21:57
Copy link
Collaborator

@cota cota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please wait for CI to pass before merging.
Thanks a lot for this!

Copy link
Collaborator

@vanbasten23 vanbasten23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM pending on the CI.

@ysiraichi ysiraichi merged commit 3f3068b into master Dec 14, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants