Adapt a few torch.utils.checkpoint functions for PyTorch/XLA.
#6178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lol I copied paste this file mostly from upstream and hoping we can merge back one day. What;s the correct way of extending the checkpoint module do you know? I copied this file because we need |
|
I have no idea. I just fixed the parts where |
JackCaoG
approved these changes
Dec 15, 2023
ysiraichi
force-pushed
the
ysiraichi/fix-checkpoint
branch
from
85ceb01 to
3d0d771
Compare
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #6086
This PR re-implements
get_device_statesandset_device_statesfunctions, used inCheckpointFunction, so as to work with PyTorch/XLA. Previously, they weren't a problem, since PyTorch was usually compiled without CUDA support.cc @JackCaoG @miladm