Set XLA_USE_SPMD for spmd cpp tests. #6273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanbasten23
force-pushed
the
set_SPMD_mode_for_spmd_test
branch
from
ca33544 to
b0d9aec
Compare
|
There seems to be a build issue? cc @vanbasten23 |
Yeah, I'm looking at it. |
miladm
reviewed
Jan 9, 2024
| class XLAShardingTest : public AtenXlaTensorTestBase { | ||
| protected: | ||
| static void SetUpTestCase() { | ||
| setenv("XLA_USE_SPMD", "1", /*overwrite=*/true); |
There was a problem hiding this comment.
big picture question: what's our plan to remove XLA_USE_SPMD flag to improve usability?
There was a problem hiding this comment.
iiuc, on the user facing level (python), we want to replace XLA_USE_SPMD with an API use_spmd(). Internally, it seems fine to keep using the flag since it doesn't affect usability. Here we use the flag only internally.
vanbasten23
force-pushed
the
set_SPMD_mode_for_spmd_test
branch
from
b0d9aec to
932bb33
Compare
|
rebased and triggered ci again |
|
Thanks for reviewing! |
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.