Use PyTorch's dynamo benchmark skip-list. #6416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zpcore
reviewed
Jan 30, 2024
zpcore
approved these changes
Jan 30, 2024
miladm
reviewed
Jan 31, 2024
| if name in self.skip["multiprocess"]: | ||
| # No support for multiprocess, yet. So, skip all benchmarks that | ||
| # only work with it. | ||
| return False |
There was a problem hiding this comment.
I wonder if we should include an "INFO" message when skipping models so it's clear on the logs - unless it gets reported elsewhere. wdyt @ysiraichi @zpcore?
There was a problem hiding this comment.
The scripts already report when a model is skipped. However, the reason is not logged. Do you think we should log that, too?
zpcore
reviewed
Jan 31, 2024
| its lists of models into sets of models. | ||
| """ | ||
|
|
||
| benchmarks_dir = self._find_near_file(("benchmarks",)) |
There was a problem hiding this comment.
It turns out pytorch/benchmarks and xla/benchmarks share the same benchmarks name. And when we search for yaml file, the nearest will be the xla/benchmarks.
amithrm
pushed a commit
to amithrm/xla
that referenced
this pull request
Mar 1, 2024
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts using PyTorch's dynamo benchmark skip-list for skipping specific models, based on the experiments' configuration. Besides that, it also:
is_compatiblefunctionadd_torchbench_dirfunctioncc @miladm