Misc bug fixes in Zero optimizer: handling differentiable argument, optimizer_dtype #6454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amithrm
changed the title
jeffhataws
reviewed
Feb 3, 2024
| # Here we pop the differentiable default because the adam family of | ||
| # optimizers don't have differentiable as an argument. This should | ||
| # be fixed by this commit https://github.com/pytorch/pytorch/pull/86183 | ||
| # and should be available in torch==2.0. For 1.13, we are patching it here. |
There was a problem hiding this comment.
Hi @amithrm , here it says "This should be fixed by this commit pytorch/pytorch#86183 and should be available in torch==2.0." Can you remove this patch?
alanwaketan
reviewed
Mar 4, 2024
jeffhataws
reviewed
Mar 11, 2024
| pin_layout=self.pin_layout, | ||
| groups=self.sharding_groups, | ||
| ) | ||
| sharded_data.append(shard_data) |
There was a problem hiding this comment.
Is this gathering all the parameters into one bucket?
|
The changes here should already be in #6025 , as confirmed by Guangtai. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a cumulative PR with misc bug fixes and updates to Zero Redundancy Optimizer from all the authors (AWS): Guangtai Huang, Rahul Solanki, Fei Wu, Amith Mamidala