Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[benchmarks] Increase compilation cache. #6509

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

ysiraichi
Copy link
Collaborator

Fix: #5967

This PR increases the compilation cache for 2 benchmarks that were failing due to an assertion error: cachedComputation.

  • cm3leon_generate
  • hf_T5_generate

It also changes the DENY_LIST so that we only skip these benchmarks if they are running on XLA without dynamo (timeout).

cc @miladm

Copy link
Collaborator

@vanbasten23 vanbasten23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@ysiraichi ysiraichi merged commit 7a1ee8f into master Feb 9, 2024
18 checks passed
amithrm pushed a commit to amithrm/xla that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[torchbench] Check failed: cachedComputation
2 participants