[benchmarks] Fix execution with AMP precision. #6512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysiraichi
requested review from
cota,
vanbasten23,
frgossen,
golechwierowicz and
zpcore
|
Hi @ysiraichi , did you see any issue recently that GPU xla backend also failed to run? I am not sure if this is related to the data format changes. |
|
Not really... |
|
Overall, LGTM. |
|
It's not exactly an error. But this is how AMP is supposed to be used. This is also how PyTorch's benchmarking script uses it (if we want to have comparable numbers). |
golechwierowicz
approved these changes
Feb 12, 2024
amithrm
pushed a commit
to amithrm/xla
that referenced
this pull request
Mar 1, 2024
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves AMP to be only activated in the forward execution.
cc @miladm