[benchmarks] Fix AMP data-type. #6550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysiraichi
requested review from
cota,
vanbasten23,
frgossen,
golechwierowicz and
zpcore
ysiraichi
force-pushed
the
ysiraichi/fix-amp-dtype
branch
from
d75a987
to
08213f3
Compare
|
@yeounoh can you review this one? I don't remember why we set the default dtype. |
|
Truth is: it was my PR that set the default AMP data-type for the benchmarking scripts. The reason being that I hadn't understood the code (linked in the OP) correctly. |
|
I have reset the AMP data-types according to whatever is the default data type in |
cota
approved these changes
Feb 16, 2024
amithrm
pushed a commit
to amithrm/xla
that referenced
this pull request
Mar 1, 2024
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the behavior of AMP, aligning it to that of PyTorch HUD. Instead of setting a default data-type, we use the default one.
cc @miladm