Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[benchmarks] Fix YAML file name. #6597

Merged
merged 1 commit into from
Feb 23, 2024
Merged

[benchmarks] Fix YAML file name. #6597

merged 1 commit into from
Feb 23, 2024

Conversation

ysiraichi
Copy link
Collaborator

This PR fixes the name of the YAML file for skipping TorchBench models modified by pytorch/pytorch#120299. Here's a brief summary:

  • torchbench_skip_models.yaml was renamed to torchbench.yaml
  • Test names are: training and inference
  • Removed a few duplicated skips

cc @miladm

@ysiraichi
Copy link
Collaborator Author

This PR should help unblocking #6542

Copy link
Collaborator

@cota cota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ysiraichi
Copy link
Collaborator Author

@cota Not sure what's the CI failure about. Do you have any idea?

@cota
Copy link
Collaborator

cota commented Feb 23, 2024

@cota Not sure what's the CI failure about. Do you have any idea?

Some authentication thing. We're working on a fix, but in the meantime, can be safely ignored. You can land the change now.

@ysiraichi ysiraichi merged commit 1a2ea9d into master Feb 23, 2024
17 of 18 checks passed
amithrm pushed a commit to amithrm/xla that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants