Automatically move CUDA non XLA Tensors to XLA Device and back to CUDA device #6644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanbasten23
reviewed
Mar 1, 2024
vanbasten23
reviewed
Mar 1, 2024
vanbasten23
reviewed
Mar 5, 2024
|
Is this an experimental pr or you want to merge this? |
Ideally we would merge this, or is there a reason not to? |
JackCaoG
reviewed
Mar 8, 2024
JackCaoG
reviewed
Mar 8, 2024
JackCaoG
reviewed
Mar 8, 2024
changm
changed the title
JackCaoG
reviewed
Mar 11, 2024
JackCaoG
reviewed
Mar 11, 2024
JackCaoG
reviewed
Mar 11, 2024
torch_xla/core/dynamo_bridge.py
Outdated
| @@ -387,6 +446,12 @@ def optimized_mod(*args): | |||
| nonlocal xla_args_need_update | |||
| nonlocal skip_checking_input_sharding_threashold | |||
|
|
|||
| original_device: torch.device = _get_input_arg_device(args) | |||
| is_cuda_args: bool = _args_on_cuda(args) | |||
There was a problem hiding this comment.
_args_on_cuda will call _get_input_arg_device which is redundant.
There was a problem hiding this comment.
I still think it's a little cleaner to do the redundant call, but removed the call here.
ysiraichi
reviewed
Mar 11, 2024
JackCaoG
approved these changes
Mar 12, 2024
JackCaoG
approved these changes
Mar 12, 2024
|
Sorry for being late. It's looking good! |
yitongh
pushed a commit
to AlibabaPAI/xla
that referenced
this pull request
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only works for inference. The assumptions don't hold for training with Autograd yet.