Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly lower div.scalar and div.tensor #6669

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Properly lower div.scalar and div.tensor #6669

merged 3 commits into from
Mar 14, 2024

Conversation

bhavya01
Copy link
Collaborator

@bhavya01 bhavya01 commented Mar 5, 2024

Lower div.scalar and div.tensor

@bhavya01 bhavya01 changed the title Properly lower div.scalar Properly lower div.scalar and div.tensor Mar 13, 2024
@bhavya01 bhavya01 marked this pull request as ready for review March 13, 2024 23:30
@bhavya01 bhavya01 requested a review from wonjoolee95 March 13, 2024 23:31
@bhavya01 bhavya01 self-assigned this Mar 13, 2024
Copy link
Collaborator

@wonjoolee95 wonjoolee95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's wait for CI to verify. Thanks!

@wonjoolee95
Copy link
Collaborator

The CI test failure test_div_promotion_xla_bool seems related, could you take a look, @bhavya01?

Copy link
Collaborator

@wonjoolee95 wonjoolee95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@wonjoolee95 wonjoolee95 merged commit 19b8383 into master Mar 14, 2024
18 checks passed
@bhavya01 bhavya01 deleted the lowerings branch March 22, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants