-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly lower add and mul #6731
Conversation
9d14293
to
997c79a
Compare
I noticed that one of the SPMD unit tests that checks HLOs failed previously and seems like the HLOs are slightly changed due to this PR because it updates the lowering logic. In this simple SPMD unit test, the HLO without this change is:
And the updated HLO looks like:
The contents of the HLOs are the same, the only things that differ is the suffix numbers, ex Synced offline with @yeounoh, this is mostly fine as it's just the numbering changed in the HLO. |
a24d373
to
1306408
Compare
Previously CI was all green, the most recent commit just rebases with master. I'll merge this now to make the rc1 branch cut. |
Partly fixes #6589