Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r2.3] backport: auto-sharding PoC (#6719) #6755

Merged
merged 2 commits into from
Mar 15, 2024
Merged

[r2.3] backport: auto-sharding PoC (#6719) #6755

merged 2 commits into from
Mar 15, 2024

Conversation

yeounoh
Copy link
Contributor

@yeounoh yeounoh commented Mar 14, 2024

@yeounoh yeounoh requested a review from lsy323 March 14, 2024 23:00
@yeounoh yeounoh self-assigned this Mar 14, 2024
@yeounoh yeounoh changed the title [SPMD] auto-sharding PoC (#6719) [r2.3] backport: auto-sharding PoC (#6719) Mar 15, 2024
@yeounoh
Copy link
Contributor Author

yeounoh commented Mar 15, 2024

@JackCaoG the build is blocked on this change, that is not backported already,

torch_xla/csrc/xla_graph_executor.cpp: In member function ‘torch::lazy::LazyGraphExecutor::SyncTensorCollection torch_xla::XLAGraphExecutor::CollectSyncTensors(const std::vector<c10::intrusive_ptr<torch_xla::XLATensor> >&, const torch::lazy::LazyGraphExecutor::SyncTensorsConfig&)’:
torch_xla/csrc/xla_graph_executor.cpp:638:62: error: ‘using element_type = struct torch_xla::XLATensor::Data’ ***aka ‘struct torch_xla::XLATensor::Data’*** has no member named ‘is_cloned’
  638 |           if (device_data != nullptr && !tensors[i]->data()->is_cloned) ***
      |                                                              ^~~~~~~~~
INFO: Elapsed time: 320.302s, Critical Path: 59.47s
INFO: 30772 processes: 15751 remote cache hit, 14836 internal, 185 local.
FAILED: Build did NOT complete successfully
FAILED: Build did NOT complete successfully
INFO: Streaming build results to: https://source.cloud.google.com/results/invocations/46e20649-0253-4ec2-9207-1d1220dc8bb7
/opt/conda/lib/python3.8/site-packages/setuptools/_distutils/cmd.py:66: SetuptoolsDeprecationWarning: setup.py install is deprecated.

This is the new change you landed. So should we just revert this part to prior to your change or we are going to back port the conflicting change, too?

@JackCaoG
Copy link
Collaborator

it is safer to revert related part of my change. My pr was a bit dangerous so I want to leave it in nightly for now.

@yeounoh yeounoh merged commit 680ebc1 into r2.3 Mar 15, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants