Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Make a FlashAttention Wrapper #6827

Merged
merged 1 commit into from
Mar 27, 2024
Merged

[Backport] Make a FlashAttention Wrapper #6827

merged 1 commit into from
Mar 27, 2024

Conversation

alanwaketan
Copy link
Collaborator

Summary:
This pull request introduces a FlashAttention wrapper that aims to:

  1. Override some default settings for the best performance out of box.
  2. Ease the UX such that users don't need to do all the custom_kernel paper works.

Test Plan:
PJRT_DEVICE=TPU python test/test_pallas.py -v -k test_flash_attention_wrapper

@alanwaketan
tmp
ed5254e 
tmp

introduce flash_attention

Add test case

Fix the test

Fix linters
@alanwaketan alanwaketan requested review from lsy323 and JackCaoG March 27, 2024 00:52
@alanwaketan alanwaketan mentioned this pull request Mar 27, 2024
Closed
JackCaoG
JackCaoG approved these changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@JackCaoG JackCaoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How many more pallas related pr you need to backport? Ideally we should not backport feature to the 2.3 branch anymore.

@alanwaketan
Copy link
Collaborator Author

Most of them are landed last week. Just they all have dependence. So I have to back port them one by one...

@alanwaketan
Copy link
Collaborator Author

The flash attention forward related feature are done. I will only backport the fixes from now on.

For backward and distributed, I won't backport them to 2.3.

@lsy323 lsy323 merged commit db7112a into r2.3 Mar 27, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackCaoG JackCaoG JackCaoG approved these changes

@lsy323 lsy323 lsy323 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alanwaketan @lsy323 @JackCaoG