Adjust allclose atol for the flash attention TPU test #6889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanwaketan
reviewed
Apr 4, 2024
test/test_pallas.py
Outdated
| @@ -205,7 +205,7 @@ def test_flash_attention_wrapper(self): | |||
|
|
|||
| o = flash_attention(q, k, v) | |||
| expected_o = self._attention(q, k, v) | |||
| self.assertTrue(torch.allclose(o.cpu(), expected_o.cpu())) | |||
| self.assertTrue(torch.allclose(o.cpu(), expected_o.cpu(), atol=1e-07)) | |||
There was a problem hiding this comment.
How about using 1e-4? Just in case.
There was a problem hiding this comment.
let's do 1e-5 lol, we also set the precision to highest in the test.
|
TPU CI passed, I am just going to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the TPU CI Failure, confirmed locally.