Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add torch_distributed tests to our TPU CI #6891

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

JackCaoG
Copy link
Collaborator

@JackCaoG JackCaoG commented Apr 5, 2024

get_xla_supported_devices will deprecate devkind after 2.3 so remove it to avoid warning for all mp tests.

@will-cromar I think now all mp workload will throw this warning since they will all call xla_replication_devices. Do you think we should just fix that in the release branch?

@JackCaoG JackCaoG requested a review from will-cromar April 5, 2024 01:00
Copy link
Collaborator

@will-cromar will-cromar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, please fix this line in the release branch if it creates log spam. devkind does nothing

@JackCaoG
Copy link
Collaborator Author

JackCaoG commented Apr 5, 2024

TPU CI is broken right now, I will hold on merging this pr.

@JackCaoG JackCaoG merged commit 44bf47c into master Apr 5, 2024
18 checks passed
@JackCaoG JackCaoG deleted the JackCaoG/add_more_tpu_ci_test branch April 5, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants