-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cherry-pick] [Fori_loop|While_loop] Create fori_loop.md (#6942) #6945
Conversation
Add doc for fori_loop/while_loop and add simple user guide for simple test case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If not all the fori_loop PRs are in r2.3, then maybe we shouldn't back-port this... I will leave it up to you and Siyuan. @ManfeiBai @lsy323 |
If user tried to run the code in the doc with 2.3 whl, would it work? if not we should not backport. |
we have so I could update this PR to only include |
Thanks, tried with 2.3RC12 wheel(torch and torch_xla) and passed test case mentioned in md file, also passed tests in |
Thanks, @lsy323, I updated the doc to only mention feature included in 2.3, do we wanna backport this doc change? |
@ManfeiBai Backport docs sounds good to me. |
Add doc for fori_loop/while_loop and add simple user guide for simple test case