Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] [Fori_loop|While_loop] Create fori_loop.md (#6942) #6945

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

ManfeiBai
Copy link
Collaborator

Add doc for fori_loop/while_loop and add simple user guide for simple test case

Add doc for fori_loop/while_loop and add simple user guide for simple test case
@ManfeiBai ManfeiBai marked this pull request as ready for review April 19, 2024 21:24
Copy link
Contributor

@yeounoh yeounoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yeounoh
Copy link
Contributor

yeounoh commented Apr 19, 2024

If not all the fori_loop PRs are in r2.3, then maybe we shouldn't back-port this... I will leave it up to you and Siyuan. @ManfeiBai @lsy323

@JackCaoG
Copy link
Collaborator

If user tried to run the code in the doc with 2.3 whl, would it work? if not we should not backport.

@ManfeiBai
Copy link
Collaborator Author

ManfeiBai commented Apr 19, 2024

If user tried to run the code in the doc with 2.3 whl, would it work? if not we should not backport.

we have while_loop and fori_loop in this PR at the same time, and we only include PR for while_loop in 2.3,

so I could update this PR to only include while_loop version, and delete fori_loop part and push local change to this branch again

@ManfeiBai
Copy link
Collaborator Author

If user tried to run the code in the doc with 2.3 whl, would it work? if not we should not backport.

Thanks, tried with 2.3RC12 wheel(torch and torch_xla) and passed test case mentioned in md file, also passed tests in test/test_fori_loop_with_while_loop_simple_add_dispatch_in_torch.py

@ManfeiBai
Copy link
Collaborator Author

If not all the fori_loop PRs are in r2.3, then maybe we shouldn't back-port this... I will leave it up to you and Siyuan. @ManfeiBai @lsy323

Thanks, @lsy323, I updated the doc to only mention feature included in 2.3, do we wanna backport this doc change?

@lsy323
Copy link
Collaborator

lsy323 commented Apr 22, 2024

@ManfeiBai Backport docs sounds good to me.

@ManfeiBai ManfeiBai merged commit 2ebd636 into pytorch:r2.3 Apr 22, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants