Update 2.3 readme #6957
Merged
Update 2.3 readme #6957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsy323
requested review from
will-cromar,
JackCaoG,
yeounoh,
mateuszlewko and
stgpetrovic
as code owners
JackCaoG
reviewed
Apr 24, 2024
README.md
Outdated
| @@ -245,6 +245,7 @@ This is only required on Cloud TPU VMs. | |||
| | Version | Cloud TPU VMs Docker | | |||
| | --- | ----------- | | |||
| | 2.3 | `us-central1-docker.pkg.dev/tpu-pytorch-releases/docker/xla:r2.3.0_3.10_tpuvm` | | |||
| | 2.2 | `us-central1-docker.pkg.dev/tpu-pytorch-releases/docker/xla:r2.2.0_3.10_tpuvm` | | |||
There was a problem hiding this comment.
can we make sure these docker actually exists before merging?
There was a problem hiding this comment.
Cannot verify the 2.3 since it's not built yet, however, we need to update the readme before the final build. See title for reason.
There was a problem hiding this comment.
On this branch, just remove all of the image and package versions. We'll update master afterwards. This README cannot change after we upload the package. (See the 2.2 release branch for an example)
There was a problem hiding this comment.
@will-cromar Thanks for the heads up, just removed
JackCaoG
approved these changes
Apr 24, 2024
|
Updated the following:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @will-cromar mentioned in the release doc, the README will be shown on the PyPI page, so update README before the final build