Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport doc fix #7159

Merged
merged 1 commit into from
May 30, 2024
Merged

Backport doc fix #7159

merged 1 commit into from
May 30, 2024

Conversation

lsy323
Copy link
Collaborator

@lsy323 lsy323 commented May 30, 2024

No description provided.

@lsy323 lsy323 marked this pull request as ready for review May 30, 2024 20:37
@ManfeiBai
Copy link
Collaborator

thanks, Siyuan, iirc, we might not want to touch r2.3 after release, do you plan to push to a new branch related to r2.3? but I'm not sure whether we still could push the doc from the new branch

@lsy323
Copy link
Collaborator Author

lsy323 commented May 30, 2024

thanks, Siyuan, iirc, we might not want to touch r2.3 after release, do you plan to push to a new branch related to r2.3? but I'm not sure whether we still could push the doc from the new branch

I don't think pushing to 2.3 branch after release is the best practice. But I don't think there is an alternative to fix the doc other than pushing to 2.3 branch.

@lsy323 lsy323 merged commit b1f2167 into r2.3 May 30, 2024
3 checks passed
@lsy323 lsy323 deleted the lsiyuan/backport branch May 30, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@will-cromar will-cromar will-cromar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lsy323 @ManfeiBai @will-cromar